tools/simulator: replace GenerateSplitKey with GenerateTableKeys

tikv / pd

Placement driver for TiKV

Apache License 2.0

1.03k stars 714 forks source link

tools/simulator: replace GenerateSplitKey with GenerateTableKeys #8332

Closed HuSharp closed 4 days ago

HuSharp commented 4 days ago

What problem does this PR solve?

GenerateSplitKey is less efficient and has some problems, such as wrong generate when start_key and end_key are same, and wrong generate when start_key is ""... Actually, we can replace GenerateSplitKey with GenerateTableKeys which is more line with test requirement

Issue Number: Ref #8135

What is changed and how does it work?

Check List

Tests

Unit test
Manual test (add detailed scripts or steps below)

Release note

None.

ti-chi-bot[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [lhy1024,nolouch] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ti-chi-bot[bot] commented 4 days ago

[LGTM Timeline notifier]

Timeline:

2024-06-26 11:26:19.166148161 +0000 UTC m=+805305.651636993: :ballot_box_with_check: agreed by lhy1024.
2024-06-27 03:46:36.231718541 +0000 UTC m=+864122.717207372: :ballot_box_with_check: agreed by nolouch.