search

tikv / pd

Placement driver for TiKV
Apache License 2.0
1.03k stars 714 forks source link

schedule: fix progress cannot display when enabling scheduling service #8334

Closed rleungx closed 3 days ago

rleungx commented 4 days ago

What problem does this PR solve?

Issue Number: Close #8331.

What is changed and how does it work?

When enabling scheduling service, use an individual function to check if the cluster is prepared.

Check List

Tests

Release note

None.
okJiang commented 4 days ago

/test pull-integration-realcluster-test

HuSharp commented 4 days ago 
--- FAIL: TestServerTestSuite (49.63s)
    --- FAIL: TestServerTestSuite/TestStoreLimit (0.24s)
        server_test.go:596: 
                Error Trace:    /home/runner/work/pd/pd/tests/integrations/mcs/scheduling/server_test.go:596
                                            /home/runner/work/pd/pd/tests/integrations/mcs/scheduling/server_test.go:550
                Error:          Should be true
                Test:           TestServerTestSuite/TestStoreLimit

ci failed, because API cluster didn't clear the environment (the suite is internally serialized), and the InitRegions called by TestOnlineProgress generated region 2 which is different from TestStoreLimit needed, causing it to fail.

ti-chi-bot[bot] commented 3 days ago

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/tikv/pd/pull/8334#pullrequestreview-2147175957): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, lhy1024, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [HuSharp,lhy1024] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 3 days ago

[LGTM Timeline notifier]

Timeline:

rleungx commented 3 days ago

/merge

ti-chi-bot[bot] commented 3 days ago

@rleungx: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: Proposal: Strengthen configuration change approval.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 3 days ago

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.