tikv / pd

Placement driver for TiKV
Apache License 2.0
1.03k stars 714 forks source link

statistics: extend store label with store id #8338

Open HuSharp opened 4 days ago

HuSharp commented 4 days ago

What problem does this PR solve?

Issue Number: Close #8337

before image after

$ ./pd-ctl store label 1 zone=c
Success! The store's label is updated.

$ ./pd-ctl store label 2 zone=b
Success! The store's label is updated.

$ ./pd-ctl store label 3 zone=c
Success! The store's label is updated.

$ ./pd-ctl config set replication.location-labels "zone"
Success!
image image

What is changed and how does it work?

Check List

Tests

Release note

None.
ti-chi-bot[bot] commented 2 days ago

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/tikv/pd/pull/8338#pullrequestreview-2147571604): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 2 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: okJiang Once this PR has been reviewed and has the lgtm label, please ask for approval from husharp, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment