scheduler: fix flaky test TestRegionLabelDenyScheduler

tikv / pd

Placement driver for TiKV

Apache License 2.0

1.03k stars 714 forks source link

scheduler: fix flaky test TestRegionLabelDenyScheduler #8340

Open okJiang opened 4 days ago

okJiang commented 4 days ago

What problem does this PR solve?

Issue Number: Close https://github.com/tikv/pd/issues/8339

What is changed and how does it work?

Ignore the specified operator instead of skipping all operators

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has the configuration change
Has HTTP API interfaces changed (Don't forget to add the declarative for the new API)
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tiup:
Need to cherry-pick to the release branch

Release note

None.

ti-chi-bot[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign lhy1024 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

okJiang commented 3 days ago

/hold

This pull request does not need to be merged, the unstable test has been reproduced

https://github.com/tikv/pd/issues/8339#issuecomment-2194304952

okJiang commented 3 days ago

/test pull-integration-realcluster-test

okJiang commented 4 hours ago

/test pull-integration-realcluster-test

okJiang commented 3 hours ago

/test pull-integration-realcluster-test

okJiang commented 3 hours ago

/unhold

okJiang commented 3 hours ago

/retest

okJiang commented 2 hours ago

This modification includes non-test changes. Do we need to add extra tests to verify it?

This content is tested by TestRegionLabelDenyScheduler.

okJiang commented 2 hours ago

/test pull-integration-realcluster-test

Do not reproduce in local environment ref https://github.com/tikv/pd/issues/8348

ti-chi-bot[bot] commented 2 hours ago

@okJiang: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

/test build

The following commands are available to trigger optional jobs:

/test pull-integration-copr-test
/test pull-integration-realcluster-test

Use /test all to run the following jobs that were automatically triggered:

tikv/pd/ghpr_build
tikv/pd/pull_integration_realcluster_test

In response to [this](https://github.com/tikv/pd/pull/8340#issuecomment-2199469799): >/test pull-integration-realcluster-test > >Do not reproduce in local environment ref https://github.com/tikv/pd/issues/8348 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

okJiang commented 2 hours ago

/test pull-integration-realcluster-test