tikv / pd

Placement driver for TiKV
Apache License 2.0
1.05k stars 721 forks source link

*: remove the previous joined pd #8562

Closed rleungx closed 2 months ago

rleungx commented 2 months ago

What problem does this PR solve?

Issue Number: Close #7954.

What is changed and how does it work?

Check List

Tests

Release note

None.
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.60%. Comparing base (6998fb5) to head (ef3a5dc). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8562 +/- ## ======================================= Coverage 77.59% 77.60% ======================================= Files 474 474 Lines 61883 61885 +2 ======================================= + Hits 48019 48024 +5 + Misses 10334 10324 -10 - Partials 3530 3537 +7 ``` | [Flag](https://app.codecov.io/gh/tikv/pd/pull/8562/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tikv/pd/pull/8562/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `77.60% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#carryforward-flags-in-the-pull-request-comment) to find out more.
ti-chi-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [HuSharp,lhy1024] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 2 months ago

[LGTM Timeline notifier]

Timeline:

HuSharp commented 2 months ago

ci failed because meeting panic :( https://github.com/tikv/pd/actions/runs/10570839546/job/29285961014?pr=8562

2024-08-27T02:54:35.0538010Z [FAIL]  mcs/scheduling TestAPI
2024-08-27T02:54:35.2144314Z === RUN   TestAPI/TestFollowerForward
2024-08-27T02:54:35.2144959Z === NAME  TestAPI
2024-08-27T02:54:35.2145730Z     testutil.go:337: start test TestFollowerForward in pd mode
...
2024-08-27T02:54:35.8353903Z [2024/08/27 02:54:34.947 +00:00] [PANIC] [cluster.go:859] ["failed to find local ID in cluster members"] [cluster-id=b2fe976be7a757da] [local-member-id=6c281856cbb0ddbe]
2024-08-27T02:54:35.8354083Z panic: failed to find local ID in cluster members
HuSharp commented 2 months ago

/hold

HuSharp commented 2 months ago

/unhold