search

tikv / pprof-rs

A Rust CPU profiler implemented with the help of backtrace-rs
Apache License 2.0
1.3k stars 99 forks source link

Optimize mutually exclusive features #130

Closed mornyx closed 2 years ago

mornyx commented 2 years ago

In general, using mutually exclusive features will cause some trouble in downstream. Some reasons can be found here: https://doc.rust-lang.org/cargo/reference/features.html#mutually-exclusive-features

Signed-off-by: mornyx mornyx.z@gmail.com

YangKeao commented 2 years ago

Please also modify the CHANGELOG.md . It's a change and we'll release a 0.10.0 version for it :cry:

mornyx commented 2 years ago

Please also modify the CHANGELOG.md . It's a change and we'll release a 0.10.0 version for it 😢

Maybe we can add a section named master to record all the latest changes and migrate them to 0.10.0 section on the next release time?

YangKeao commented 2 years ago

@mornyx

The [Unreleased] section?

mornyx commented 2 years ago

The [Unreleased] section?

Oh, that's it! How about I add it to [Unreleased] first? Maybe this change wasn't enough to release a version on its own.

mornyx commented 2 years ago

Should this be Changed or Removed, what is your opinion? 🤔

YangKeao commented 2 years ago

Oh, that's it! How about I add it to [Unreleased] first? Maybe this change wasn't enough to release a version on its own.

Yes. It's expected. I'll rename the Unreleased to 0.10.0 and create a new Unreleased when I release that version.

Should this be Changed or Removed, what is your opinion?

IMO, Changed is better.

mornyx commented 2 years ago

/assign @YangKeao Ping~ Please see if there is any room for improvement.