Closed victoryang00 closed 1 year ago
Cool, please add sign-off through git commit -s --amend
Cool, please add sign-off through
git commit -s --amend
fixed
Would you mind rebase the master, as https://github.com/tikv/pprof-rs/pull/175 should have fixed the CI error :thinking: .
Another thing is that would you mind also support frame pointer for riscv? Like https://github.com/tikv/pprof-rs/pull/174/files#diff-8fa537005d71550f49aaa53c3d12aa6356b8a9f8699fee61ead4f83f93128e52R77 . (Though I know nothing about the RISC-V convention on frame pointer. If this suggestion is not realistic, just ignore it.)
#[cfg(all(target_arch = "riscv64", target_os = "linux"))]
let frame_pointer = unsafe { (*ucontext).uc_mcontext.__gregs[libc::REG_S0] as usize };
added frame pointer support, in riscv ABI, s0 is fp.
I'm doing homework that runs tikv and risingwave riscv64 version and encountered compiling error when going through pprof.
Add support for riscv64 with pc support.
There's no
riscv64gc-unknown-linux-gnu
CI machine. My proposal is to add a specific test that uses the following in.cargo/config.toml
to run riscv64 benches and tests.