tikv / pprof-rs

A Rust CPU profiler implemented with the help of backtrace-rs
Apache License 2.0
1.26k stars 94 forks source link

Bump the MSRV to 1.64.0 #204

Closed hi-rustin closed 1 year ago

hi-rustin commented 1 year ago

If the rust toolchain lower than v1.64.0 then you will get a compile error:

error[E0106]: missing lifetime specifier
  --> /Users/hi-rustin/.cargo/registry/src/github.com-1ecc6299db9ec823/inferno-0.11.15/src/flamegraph/color/mod.rs:83:25
   |
83 |     pub const VARIANTS: &[&'static str] = &[
   |                         ^ expected named lifetime parameter
   |
help: consider using the `'static` lifetime
   |
83 |     pub const VARIANTS: &'static [&'static str] = &[
   |                          +++++++
help: consider introducing a named lifetime parameter
   |
81 ~ impl<'a> Palette {
82 |     /// The valid set of palettes (via `FromStr`).
83 ~     pub const VARIANTS: &'a [&'static str] = &[
hi-rustin commented 1 year ago

Also, you can see an error for other packages:

error: package `rayon-core v1.11.0` cannot be built because it requires rustc 1.59 or newer, while the currently active rustc version is 1.56.1
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

See: https://github.com/tikv/pprof-rs/actions/runs/4474804380/jobs/7863621636

error: package `prost v0.11.8` cannot be built because it requires rustc 1.60 or newer, while the currently active rustc version is 1.56.1
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

See: https://github.com/tikv/pprof-rs/actions/runs/4474804380/jobs/7863622817?pr=204

hi-rustin commented 1 year ago

Thanks for your review! 💚 💙 💜 💛 ❤️