search

tikv / pprof-rs

A Rust CPU profiler implemented with the help of backtrace-rs
Apache License 2.0
1.26k stars 94 forks source link

chore: Update `prost`, `prost-derive` and `prost-build` to `0.12` #223

Closed alamb closed 9 months ago

alamb commented 9 months ago

Rationale:

prost has been updated and it would be nice for downstream crates (like IOx) to not have multiple versions of prost

Changes:

alamb commented 9 months ago

cc @YangKeao @Xuanwo

YangKeao commented 9 months ago

CI failed because we need to bump the MSRV. See: https://github.com/tikv/pprof-rs/pull/225

YangKeao commented 9 months ago

Please rebase the master. Then it should pass the CI 🍻

alamb commented 9 months ago

Please rebase the master. Then it should pass the CI 🍻

Done!

alamb commented 9 months ago

I believe https://github.com/tikv/pprof-rs/pull/224 will need to be merged first to get the CI to pass cleanly

sticnarf commented 9 months ago

Can you help run rm proto/perftools.profiles.rs && cargo check --features prost-codec to update the pre-compiled prost source? Then, CI will be happy.

alamb commented 9 months ago

🎉 -- thank you so much for all the help @sticnarf and @YangKeao