search

tikv / pprof-rs

A Rust CPU profiler implemented with the help of backtrace-rs
Apache License 2.0
1.26k stars 94 forks source link

Modify the CI to execute on 1.64.0 #225

Closed YangKeao closed 9 months ago

YangKeao commented 9 months ago 
error: package `addr2line v0.21.0` cannot be built because it requires rustc 1.65 or newer, while the currently active rustc version is 1.64.0

After patching the minor version of pprof-rs, it can actually run on 1.64.0

sticnarf commented 9 months ago

As I replied in #221, addr2line 0.21 does not force us to bump MSRV to 1.65 because it's possible to keep the patch version of backtrace low enough.

YangKeao commented 9 months ago

As I replied in #221, addr2line 0.21 does not force us to bump MSRV to 1.65 because it's possible to keep the patch version of backtrace low enough.

Thanks for the information. Then I'll not bump the MSRV in this PR, but just commit the Cargo.lock and make sure the CI passes. PTAL @sticnarf