search

tikv / raft-engine

A persistent storage engine for Multi-Raft log
Apache License 2.0
565 stars 88 forks source link

run asan in CI and stabilize write barrier test #120

Closed tabokie closed 3 years ago

tabokie commented 3 years ago

Signed-off-by: tabokie xy.tao@outlook.com

Run ASAN in linux CI pipeline. The write barrier test is unstable when ran under asan/miri, fixing it. Also some housekeeping work: remove build step in CI, remove useless code.

TSAN still can't run because we use crossbeam channel for parallel recovery.

skyzh commented 3 years ago

Crossbeam channel will definitely cause race condition, as a feature. So this won’t work.

skyzh commented 3 years ago

Crossbeam channel will definitely cause race condition, as a feature. So this won’t work.

FYI https://github.com/tikv/agatedb/issues/51

tabokie commented 3 years ago

Crossbeam channel will definitely cause race condition, as a feature. So this won’t work.

FYI tikv/agatedb#51

Thanks for the pointer, but crossbeam is actually not needed anymore after #77.

Anyhow, sanitizer currently can't build, seemingly caused by https://github.com/HdrHistogram/HdrHistogram_rust. I might look into that later.

skyzh commented 3 years ago

BTW, running ASAN also requires -Zbuild-std --target x86_64-unknown-linux-gnu.