search

tikv / raft-engine

A persistent storage engine for Multi-Raft log
Apache License 2.0
565 stars 88 forks source link

Replace app builder with derive macros in stress tool #163

Closed ztelur closed 2 years ago

ztelur commented 2 years ago

replace structopt with clap-v3.0.0-beta.5 in ctl and stress tool referred to #155

Close #155.

ztelur commented 2 years ago

/cc @tabokie

codecov[bot] commented 2 years ago

Codecov Report

Merging #163 (4742f37) into master (90a50b7) will increase coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   96.96%   96.98%   +0.01%     
==========================================
  Files          26       26              
  Lines        6597     6597              
==========================================
+ Hits         6397     6398       +1     
+ Misses        200      199       -1
Impacted Files Coverage Δ
src/codec.rs 98.67% <0.00%> (+0.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 90a50b7...4742f37. Read the comment docs.

ztelur commented 2 years ago

Could you remove Cargo.lock from you changeset? After that you can also add "Cargo.lock" to gitignore.

Done

ztelur commented 2 years ago

BTW, running stress with default parameter value will lead to error "Write region count must be smaller than region-count / write-threads". Should we change the default value of those three parameters target/debug/stress --path tmp

tabokie commented 2 years ago

BTW, running stress with default parameter value will lead to error "Write region count must be smaller than region-count / write-threads". Should we change the default value of those three parameters target/debug/stress --path tmp

@ztelur Please do.