Closed tabokie closed 2 years ago
/cc @LykxSassinator
Base: 97.65% // Head: 97.66% // Increases project coverage by +0.01%
:tada:
Coverage data is based on head (
3e15000
) compared to base (9751c6d
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Ping @Connor1996 , this one is blocking #261
This is a preparing work for #258.
Changes:
fsync
to file handle instead of writer, so that we can call it concurrently in the future. In doing so, we have to remove the sync offset tracking and deprecatebytes_per_sync
supportprepare_write
into pipe_log. Introduce a traitReactiveBytes
for this purpose.