tikv / raft-engine

A persistent storage engine for Multi-Raft log
Apache License 2.0
564 stars 88 forks source link

recycle: optimize the recycling progress by reducing one redundant RENAME operation. #308

Closed LykxSassinator closed 1 year ago

LykxSassinator commented 1 year ago

Description

This pr is used for optimizing the progress of recycle, by eliminating one redundant RENAME operation. In this pr:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 98.30% and project coverage change: -0.05 :warning:

Comparison is base (205b5d7) 97.92% compared to head (250d049) 97.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #308 +/- ## ========================================== - Coverage 97.92% 97.88% -0.05% ========================================== Files 31 31 Lines 12189 12226 +37 ========================================== + Hits 11936 11967 +31 - Misses 253 259 +6 ``` | [Impacted Files](https://app.codecov.io/gh/tikv/raft-engine/pull/308?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [src/file\_pipe\_log/mod.rs](https://app.codecov.io/gh/tikv/raft-engine/pull/308?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-c3JjL2ZpbGVfcGlwZV9sb2cvbW9kLnJz) | `98.45% <ø> (ø)` | | | [src/file\_pipe\_log/pipe\_builder.rs](https://app.codecov.io/gh/tikv/raft-engine/pull/308?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-c3JjL2ZpbGVfcGlwZV9sb2cvcGlwZV9idWlsZGVyLnJz) | `96.05% <97.22%> (+0.07%)` | :arrow_up: | | [src/file\_pipe\_log/pipe.rs](https://app.codecov.io/gh/tikv/raft-engine/pull/308?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-c3JjL2ZpbGVfcGlwZV9sb2cvcGlwZS5ycw==) | `98.16% <98.21%> (+0.08%)` | :arrow_up: | | [src/engine.rs](https://app.codecov.io/gh/tikv/raft-engine/pull/308?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-c3JjL2VuZ2luZS5ycw==) | `98.63% <100.00%> (+<0.01%)` | :arrow_up: | | [src/file\_pipe\_log/format.rs](https://app.codecov.io/gh/tikv/raft-engine/pull/308?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-c3JjL2ZpbGVfcGlwZV9sb2cvZm9ybWF0LnJz) | `99.05% <100.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/tikv/raft-engine/pull/308/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

LykxSassinator commented 1 year ago

/cc @tabokie PTAL, thx.

LykxSassinator commented 1 year ago

As the related work in this pr has been merged into the pr: https://github.com/tikv/raft-engine/pull/310, this pr can be closed.