search

tikv / raft-engine

A persistent storage engine for Multi-Raft log
Apache License 2.0
564 stars 88 forks source link

Revert rustc version #345

Closed v01dstar closed 11 months ago

v01dstar commented 11 months ago

Turns out it is better to still use rustc 1.66.0, otherwise the downstream TiKV project would require a lot of refactoring works if it wants to update its raft-engine version.

I bumped the version in #343 becauseserde requires rustc > 1.67 for stable build. Seems that we get the CI passed, we just need to update the CI's toolchain version, instead of updating the rustc requirement of raft-engine.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e8de5d7) 98.21% compared to head (9e6a55c) 98.20%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #345 +/- ## ========================================== - Coverage 98.21% 98.20% -0.01% ========================================== Files 33 33 Lines 12457 12457 ========================================== - Hits 12235 12234 -1 - Misses 222 223 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Connor1996 commented 11 months ago

/merge

tabokie commented 11 months ago

Just a nitpick, you should use cargo patch to lock the version of toml to get around this issue. Setting a MSRV lower than actually required is not friendly to potential users. And CI and MSRV must align, that's the point of explicitly setting one in the first place.