search

tikv / raft-rs

Raft distributed consensus algorithm implemented in Rust.
Apache License 2.0
2.86k stars 391 forks source link

Update to Prost 0.11 #496

Closed agourlay closed 1 year ago

agourlay commented 1 year ago

This PR update to Prost 0.11.

Protobuf-build has been already updated https://github.com/tikv/protobuf-build/pull/63

BusyJay commented 1 year ago

protoc is also missing

agourlay commented 1 year ago

I need to find a way to install protoc across all OS configurations

agourlay commented 1 year ago

@BusyJay all green :green_circle:

I used the same action as the prost CI https://github.com/tokio-rs/prost/blob/master/.github/workflows/continuous-integration-workflow.yaml#L81

BusyJay commented 1 year ago

How about using package manager instead? I'm worried about the permissions of secrets.

On Windows, it can be installed by choco install protoc, on MacOS it can be done by brew install protobuf, on Linux, it can be done by sudo apt-get install protobuf-compiler.

agourlay commented 1 year ago

@BusyJay No worries, I was able to use each package managers instead.