search

tikv / raft-rs

Raft distributed consensus algorithm implemented in Rust.
Apache License 2.0
2.86k stars 391 forks source link

Confusion about comments in raft.rs at line 1630 #527

Closed wego1236 closed 6 months ago

wego1236 commented 10 months ago

https://github.com/tikv/raft-rs/blob/cd621e4c7bdf4278e970e13ea236bb0559c9f21b/src/raft.rs#L1629C45-L1630C60

I was reviewing the code in src/raft.rs and got a bit confused about the comments at line 1630. It has previously stated that the content of the letter replied to from follower is 'RejectHint of 6 and LogTerm of 2', but here it says that it tells the leader that it is still at term 2 at index 9. I think this should be changed to ' But the follower already told the leader that it is still at term 2 at index 6' . In other words, i think this should be changed from index 9 to 6

BusyJay commented 10 months ago

You are correct. Can you send a PR to fix it?

wego1236 commented 10 months ago

Sure, I'll go now.

------------------ 原始邮件 ------------------ 发件人: @.>; 发送时间: 2023年9月14日(星期四) 下午2:40 收件人: @.>; 抄送: @.>; @.>; 主题: Re: [tikv/raft-rs] Confusion about comments in raft.rs at line 1630 (Issue #527)

You are correct. Can you send a PR to fix it?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>