tikv / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.
http://rocksdb.org
GNU General Public License v2.0
119 stars 92 forks source link

Fix bloom filter compatibility issue caused by naming #365

Closed v01dstar closed 1 month ago

v01dstar commented 2 months ago

https://github.com/tikv/tikv/issues/17272 This is a temp fix for 6.29. Will propose a different fix for 8.10.

Since TiKV only uses RocksDB builtin bloom filters, this should be able to fix the issue. Also planning to revert the PR that introduced this bug in rust-rocksdb, i.e. remove the suffix like ".FullBloom", "BlockBloom" and "Ribbon". After all, "BlockBloom" has been deprecated in RocksDB newer versions anyway.

v01dstar commented 2 months ago

@hbisheng