tikv / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.
http://rocksdb.org
GNU General Public License v2.0
120 stars 93 forks source link

Strengthen reviewing controlling #367

Closed wuhuizuo closed 2 months ago

wuhuizuo commented 2 months ago

Strengthen reviewing controlling

An approval process for the change to the file path scope of global variables and configurations will be deployed.

Why

The current reviewers and approvers are too vague with organization level(https://github.com/tikv/community/blob/master/teams/tikv/team.json) and are not subdivided into specific repositories or areas, can not fine-grained control over changes in this repository. In order to make the review process more precise and standardized, we plan to deploy the review control plugin in the "tikv/rocksdb" repository and delegate approval responsibilities to active "maintainers" and "committers" of this repository.

What's new for developer

Ref:

Set up

  1. Now we use prow's OWNERS mechanism to control the approving for pull requests, here is the PR review flow.
  2. OWNERS files should be updated on time.

Role and Responsibility

wuhuizuo commented 2 months ago

/type enhancement