Closed v01dstar closed 2 months ago
/run-all-test
/run-all-tests
/run-all-tests
/run-all-tests
/run-all-tests
@hbisheng
@LykxSassinator: adding LGTM is restricted to approvers and reviewers in OWNERS files.
@SpadeA-Tang: adding LGTM is restricted to approvers and reviewers in OWNERS files.
wait for merging of #376.
/lgtm
refresh
@wuhuizuo: adding LGTM is restricted to approvers and reviewers in OWNERS files.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: LykxSassinator, SpadeA-Tang, wuhuizuo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Timeline:
2024-09-24 13:05:32.608226997 +0000 UTC m=+1571202.348650935
: :heavy_multiplication_x::repeat: reset by ti-chi-bot.New changes are detected. LGTM label has been removed.
Merge https://github.com/tikv/rocksdb/pull/381 with this for future cherry-pick.
This PR are following PRs combined:
The WriteAmpBasedRateLimiter automatically adjusts rate limiting by predicting I/O trends using heuristic methods based on the write amplification factor. e.g. a high write throughput with
HIGH
priority (flush) implies, highly likely, there will beLOW
priority write throughput soon, because RocksDB needs to compact the L0 files to lower levels, it is better to provision in advance. Compared to the default rate limiter, it reduces the likelihood of triggering write stalls and helps prevent I/O jitter.Comments:
LOW
,MID
,HIGH
,USER
instead of justLOW
andHIGH
, write amplification rate limiter's tuning logic may need to adjust to this change.