Closed v01dstar closed 1 month ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Connor1996, glorv, LykxSassinator
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Timeline:
2024-09-30 09:00:19.622230151 +0000 UTC m=+258975.042443175
: :ballot_box_with_check: agreed by Connor1996.2024-09-30 09:02:01.344013559 +0000 UTC m=+259076.764226571
: :ballot_box_with_check: agreed by LykxSassinator.2024-09-30 23:26:32.311899715 +0000 UTC m=+310947.732112728
: :heavy_multiplication_x::repeat: reset by v01dstar.New changes are detected. LGTM label has been removed.
Statistics
extensible, this is a cherry-pick of 7c6dcaa496564ec49cb1a135cfbf9e0a22cb31c5. In addition to the original PR, this new one also instantiateStatisticsImpl
template at the end ofstatistics.cc
to resolve visibility issues in testsColumnFamilyHandle
, this is a prerequisite of https://github.com/tikv/titan/pull/298ValueType::0x11
tokTypeTitanBlobIndex
, and create a newkTypeBlobIndex
(RocksDB native blob index) at 0x18, so that Titan blob index can be distinguished from RocksDB's native blob index, thus won't get mistakenly parsed by RocksDB and cause panic. Existing Titan instances don't need to migrate.In the future, we need to merge this with #390 , attaching #390 description here:
ValueType
0x10 tokTypeTitanColumnFamilyBlobIndex
and 0x11 tokTypeTitanBlobIndex
, and addWriteBatchInternal::PutTitanBlobIndex()
for Titan to use.StatisticsImpl
implementation from statistics.cc to statistics_impl.h. Template code should be in header files instead of cc files, otherwise, there will beundefined symbol
error while linking.Maintainer's note: When upgrading RocksDB in the future, we need to check all the occurrence of
kTypeBlobIndex
andkTypeColumnFamilyBlobIndex
(for blob indices in non-default cf) in RocksDB's repo, and addkTypeTitanBlobIndex
andkTypeTitanColumnFamilyBlobIndex
accordingly. AnywherekTypeColumnFamilyBlobIndex
exists, we need to addkTypeTitanColumnFamilyBlobIndex
, wherekTypeBlobIndex
exists, we need to addkTypeTitanBlobIndex
.