tikv / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.
http://rocksdb.org
GNU General Public License v2.0
120 stars 93 forks source link

Add FORCE_SSE compile option #391

Closed v01dstar closed 1 month ago

v01dstar commented 1 month ago

FORCE_SSE has been deprecated in RocksDB upstream. It recommends using PORTABLE=min_cpu_arch to turn on the compiling optimizations. e.g. PORTABLE=haswell, which will then propagate to the compiler option -march=haswell and then turn on SSE. However, I guess TiKV can't assume CPU arch. So the best option for TiKV woud be PORTABLE=x86-64-v2. While, current PingCAP CI's gcc version does not support x86-64-v2 yet. For now, we can just add that FORCE_SSE back.

Removing HOMEPAGE_URL https://rocksdb.org/, since it needs CMake > 3.12, while PingCAP CI now only support CMake 3.10

v01dstar commented 1 month ago

/run-all-tests

glorv commented 1 month ago

/test

ti-chi-bot[bot] commented 1 month ago

@glorv: No presubmit jobs available for tikv/rocksdb@8.10.tikv

In response to [this](https://github.com/tikv/rocksdb/pull/391#issuecomment-2398935782): >/test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
glorv commented 1 month ago

/run-all-tests

ti-chi-bot[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LykxSassinator, overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/rocksdb/blob/8.10.tikv/OWNERS)~~ [LykxSassinator,overvenus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 1 month ago

[LGTM Timeline notifier]

Timeline: