Closed v01dstar closed 1 month ago
/run-all-tests
/test
@glorv: No presubmit jobs available for tikv/rocksdb@8.10.tikv
/run-all-tests
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: LykxSassinator, overvenus
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Timeline:
2024-10-08 06:34:09.604621331 +0000 UTC m=+941405.024834335
: :ballot_box_with_check: agreed by LykxSassinator.2024-10-08 06:47:26.861341404 +0000 UTC m=+942202.281554416
: :ballot_box_with_check: agreed by overvenus.
FORCE_SSE
has been deprecated in RocksDB upstream. It recommends usingPORTABLE=min_cpu_arch
to turn on the compiling optimizations. e.g.PORTABLE=haswell
, which will then propagate to the compiler option-march=haswell
and then turn on SSE. However, I guess TiKV can't assume CPU arch. So the best option for TiKV woud bePORTABLE=x86-64-v2
. While, current PingCAP CI's gcc version does not supportx86-64-v2
yet. For now, we can just add thatFORCE_SSE
back.Removing
HOMEPAGE_URL https://rocksdb.org/
, since it needs CMake > 3.12, while PingCAP CI now only support CMake 3.10