search

tikv / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.
http://rocksdb.org
GNU General Public License v2.0
120 stars 93 forks source link

Add enable_pipelined_commit as deprecated option #397

Closed v01dstar closed 4 weeks ago

v01dstar commented 1 month ago

enable_pipelined_commit was introduced by TiKV before, but got renamed to enable_multi_batch_write later. However, there are some versions of TiKV still running with enable_pipelined_commit (either false or true) persisted in OPTIONS-xxxx file under RocksDB directory, when upgrading these TiKVs, they will panic because of "load_latest_options" who reads the OPTIONS-xxxx does not recognize the option.

Now, add this option as a deprecated option, so that, it won't cause a InvalidArgument panic, nor will it be serialized in OPTIONS-xxxx files anymore.

ti-chi-bot[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, LykxSassinator

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/rocksdb/blob/8.10.tikv/OWNERS)~~ [LykxSassinator] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 4 weeks ago

[LGTM Timeline notifier]

Timeline: