search

tikv / rust-prometheus

Prometheus instrumentation library for Rust applications
Apache License 2.0
1.07k stars 182 forks source link

Allow trailing commas on macros #390

Closed HyeonuPark closed 3 years ago

HyeonuPark commented 3 years ago

This PR allows to append optional comma after the last argument of those opts!/register! like macros.

HyeonuPark commented 3 years ago

I guess all I needs to do for the DCO issue is to append the Signed-off-by: line to the commit msg. Maybe it was a mistake to make the change directly on the GH web editor, which makes it nontrivial to simply change the commit msg :P

lucab commented 3 years ago

@HyeonuPark thanks for the PR! Indeed, your commit should be signed off to pass CI checks. Travis failure is due to https://github.com/tikv/rust-prometheus/pull/391 and should go away if you rebase to latest master.

lucab commented 3 years ago

@HyeonuPark ping, do you plan to come back to this soon-ish?

HyeonuPark commented 3 years ago

Sorry for the super late reply! If it's still OK, I'll supplement it within this week.

HyeonuPark commented 3 years ago

Shameless copy-pastes from doc comments with additional comma per invocation. :) I can't say anymore it's a tiny change w.r.t. the LoC.

HyeonuPark commented 3 years ago

Applied cargo fmt on it.

lucab commented 3 years ago

Thanks a lot, LGTM!