search

tikv / rust-prometheus

Prometheus instrumentation library for Rust applications
Apache License 2.0
1.05k stars 182 forks source link

process_collector: fix compilation on 32-bit targets #446

Closed jedisct1 closed 2 years ago

jedisct1 commented 2 years ago

The crate didn't compile on 32-bit targets any more due to libc::sysconf() returning a 32-bit value on those targets.

Fixes #442

lucab commented 2 years ago

LGTM, thanks for the patch, can you please sign-off your commit?

jedisct1 commented 2 years ago

LGTM, thanks for the patch, can you please sign-off your commit?

Done!

yinheli commented 2 years ago

ping @lucab @overvenus, Could you please publish this to crates.io ?

jedisct1 commented 2 years ago

@yinheli meanwhile your can use the prometheus-32bitfix crate.

lucab commented 2 years ago

Oh yes sorry, I wanted to tackle https://github.com/tikv/rust-prometheus/issues/451 too before releasing but never found proper time for that. Let's not delay this any longer and cut 0.13.2 directly, PR at https://github.com/tikv/rust-prometheus/pull/457.