Use rocksdb SyncPoint to support fail-rs

yiwu-arbug commented 5 years ago

To allow integration test frameworks to control rocksdb internals, we can make use of rocksdb SyncPoint to support rust fail-point https://github.com/tikv/fail-rs There are some difference between SyncPoint and fail-point. Some of the items to work on:

[ ] Make fail-point support dependencies (one fail-point wait for another before proceed)
[ ] Make SyncPoint support early return
[ ] Add rocksdb compile flag to enable SyncPoint in release build
[ ] Expose SyncPoint API on rocksdb side, then wrap it as fail-point API on rust-rocksdb side

yiwu-arbug commented 5 years ago

cc @Connor1996

Connor1996 commented 5 years ago

Very useful!

Sullivan12138 commented 4 years ago

I would like to take this task, and choose the exposing syncpoint's API part

yiwu-arbug commented 4 years ago

https://github.com/facebook/rocksdb/issues/6087

Sullivan12138 commented 4 years ago

Sorry, there's another task that invite me to do, so I may have to quit

tikv / rust-rocksdb

Use rocksdb SyncPoint to support fail-rs #361