search

tikv / rust-rocksdb

rust wrapper for rocksdb
Apache License 2.0
278 stars 155 forks source link

Allow setting write_global_seqno option #631

Closed v01dstar closed 3 years ago

v01dstar commented 3 years ago

See the issue here

This PR provides the Rust API of setting IngestExternalFileOptions::write_global_seqno

Signed-off-by: Yang Zhang yang.zhang@pingcap.com

v01dstar commented 3 years ago

@yiwu-arbug PTAL

  1. I tried to add a unit test, which compared the global_seq_no before and after the ingestion, and it seemed to me that this number either never changed throughout the ingestion or got cleared after the ingestion w/ the option set to true. That means the test could not verify that whether the option was effective or not. So I did not include a test here. Do you have better ideas of testing the propagation of this option? Or it is fine to leave it not covered by tests?
  2. Since librocksdb_sys/crocksdb/crocksdb/c.h is changed, should I also include the change generated by the build tool in librocksdb_sys/bindings/x86_64-unknown-linux-gnu-bindings.rs in this PR?
v01dstar commented 3 years ago

Included binging changes, also added a getter method for unit testing.

Connor1996 commented 3 years ago

And please fix the sign-off

v01dstar commented 3 years ago

Adding signed-off. Signed-off-by: Yang Zhang yang.zhang@pingcap.com

yiwu-arbug commented 3 years ago

/merge

ti-srebot commented 3 years ago

/run-all-tests