Allow compaction filter on flush

tikv / rust-rocksdb

rust wrapper for rocksdb

Apache License 2.0

278 stars 155 forks source link

Allow compaction filter on flush #635

Closed MrCroxx closed 3 years ago

MrCroxx commented 3 years ago

Allow compaction filter on flush.

Ref: tikv/rocksdb#pr243

TODO:

[x] Redirect submodule rocksdb back to tikv/rocksdb branch 6.4.tikv after pull#243 is merged.

MrCroxx commented 3 years ago

/cc @tabokie @hicqu

MrCroxx commented 3 years ago

I really don't know why are we using C++ style enum definition here. With that style you shouldn't drop the leading k, instead use something like kForFlush. Or IMO you could start using C style again to avoid collision, like here.

@tabokie I agree with you, C style enum will be better here.

MrCroxx commented 3 years ago

All tests passed locally. Ready to be merged.

@tabokie PTAL