search

tikv / rust-rocksdb

rust wrapper for rocksdb
Apache License 2.0
278 stars 155 forks source link

fix mac build #644

Closed yiwu-arbug closed 3 years ago

yiwu-arbug commented 3 years ago

It appears on MacOS with Clang, bool is not supported in C, causing compile error. Changing it to char.

Signed-off-by: Yi Wu yiwu@pingcap.com

MrCroxx commented 3 years ago

Or unsigned char?

IMO char is fine, like the most libs.

ti-srebot commented 3 years ago

@MrCroxx, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: engine(slack).

tabokie commented 3 years ago

Or unsigned char?

IMO char is fine, like the most libs.

"most libs" is not relevant here. What's relevant is consistency within "this lib".

yiwu-arbug commented 3 years ago

Updated all boolean in crocksdb into unsigned char.