search

tikv / rust-rocksdb

rust wrapper for rocksdb
Apache License 2.0
278 stars 155 forks source link

Fix WriteBatch::iterate memory leak #658

Closed yuqi1129 closed 3 years ago

yuqi1129 commented 3 years ago

Fix https://github.com/tikv/rust-rocksdb/issues/654

yuqi1129 commented 3 years ago

I wander to know if it's necessary to add some test and how to test this memory leak like this ?

Connor1996 commented 3 years ago

I wander to know if it's necessary to add some test and how to test this memory leak like this ?

Seems hard to test.

Connor1996 commented 3 years ago

@yiwu-arbug How did you find this memory leak?

yiwu-arbug commented 3 years ago

@yiwu-arbug How did you find this memory leak?

@Little-Wallace told me he left the bug behind XD