search

tikv / rust-rocksdb

rust wrapper for rocksdb
Apache License 2.0
276 stars 155 forks source link

port write buffer manager and compaction thread limiter #726

Closed tabokie closed 1 year ago

tabokie commented 1 year ago

For https://github.com/tikv/rocksdb/pull/305 and https://github.com/facebook/rocksdb/pull/4332.

Also, refactor rate limiter for sharing between instances.

ti-srebot commented 1 year ago

@tonyxuqqi, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: engine(slack).

ti-srebot commented 1 year ago

@tonyxuqqi, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: engine(slack).

tonyxuqqi commented 1 year ago

get/set_rate_bytes_per_sec, get/set_auto_tuned, get_and_reset_statistics_ticker_count, get_statistics_histogram reset_statistics

These methods are needed to compile the current TiKV node.

tabokie commented 1 year ago

@tonyxuqqi The changes are by design. See https://github.com/tikv/tikv/pull/13984