tikv / rust-rocksdb

rust wrapper for rocksdb
Apache License 2.0
276 stars 155 forks source link

port some filter enhancements #740

Closed tabokie closed 1 year ago

tabokie commented 1 year ago

ribbon filter and optimize_filters_for_memory, both only effective when format_version >= 5.

ti-srebot commented 1 year ago

@tonyxuqqi, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. get siglist: dial tcp 172.16.4.167:34000: connect: no route to host

tonyxuqqi commented 1 year ago
Screen Shot 2023-04-05 at 7 06 19 PM

It looks that after using the ribbon filter, the filter insert volume in block cache is reduced from ~2GB/s to < 20MB/s.