tikv / rust-rocksdb

rust wrapper for rocksdb
Apache License 2.0
276 stars 155 forks source link

Revert bloom filter name extension #794

Closed v01dstar closed 1 month ago

v01dstar commented 1 month ago

Apply RocksDB fix https://github.com/tikv/rocksdb/pull/365, which uses prefix match instead of exact match for determining whether a bloom filter is compatible or not.

Also, revert the change that added the filter type as suffix, since it is unnecessary (all internal filters can be used interchangeably), and is causing compatibility issues (https://github.com/tikv/tikv/issues/17272), i.e. SSTs created before 7.1 with filter meta block named using rocksdb.BuiltinBloomFilter are no longer recognized by newer versions of TiKV.

We will probably have to maintain the customized change "prefix match" for a while, to make sure impacted versions are migrated smoothly.