tilboerner / depx

Examine and visualize dependencies used by Python modules 🔍
Other
19 stars 3 forks source link

Add support for python2.7 #24

Closed fabiocerqueira closed 4 years ago

fabiocerqueira commented 5 years ago

Python 2.7 won't be officially supported next year(2020), but it will still alive in thousands of companies. This PR allows depx parser python2.7 and python3 code

anapaulagomes commented 5 years ago

@tilboerner would you do us the honors of this review?

tilboerner commented 5 years ago

@anapaulagomes I'll be happy to review, but I won't be able to until next week when I'm back from vacation. :)

anapaulagomes commented 5 years ago

Take your time (and enjoy your vacation). 🍸 @tilboerner

fabiocerqueira commented 5 years ago

@anapaulagomes depx still requires Python 3.4+ to run but you can inspect/parser Python 2 code with it, too. So, there is no need to add py27 to the tox.ini

fabiocerqueira commented 5 years ago

@tilboerner I'll have a look in your comments, but I'll answer or apply the change only next week. Thanks for the review :D

tilboerner commented 5 years ago

@fabiocerqueira @anapaulagomes I've been thinking about this some more, and now I believe it would be best to have a command-line switch to force --py2 parsing, and use the builtin ast otherwise. Here are my reasons:

What do you guys think?

tilboerner commented 4 years ago

Stale PR, closing.