Closed wagnerpeer closed 3 years ago
The checks fail, however Python <3.6 reached its EOL! Should be considered to drop support.
Hi @wagnerpeer, thanks a lot for this PR! I'm one of the original authors and just took over this project a couple of days ago - you roused it from its dormant state and made us realize we need to sort out who will maintain it. Please note that the upstream changed to https://github.com/tilboerner/depx/
.
I also dropped support for Python 3.4 and switched dependency management over to Poetry. That means your fix of the dependencies is now unnecessary. Sorry about that, and thanks for doing it, much appreciated!
If you'd like, could you please rebase off of the new master
and resubmit? I can also do it if you prefer, but I'd rather not take over your whole contribution without asking first. :)
One thing though: The PR currently installs 2 instances of black
. One for pre-commit, one in the project dependencies. Formatting rules sometimes change between black versions, and it would be better to install it only once, so the versions can't get out of sync and cause conflicts. So I think either pre-commit should use the local black from the project dependencies; or we drop it from the dependencies, and people need to access it through pre-commit.
This PR adresses issue #16
Adds black to development requirements
Adds pyproject.toml file to configure black
Reformats project using black
Adds pre-commit to development requirements
Adds pre-commit configuration
Updates all requirements files, because of changes in dev requirements