Enable check suite - Githubissues

tilboerner / depx

Examine and visualize dependencies used by Python modules 🔍

Other

19 stars 3 forks source link

Enable check suite #8

Closed codingjoe closed 5 years ago

codingjoe commented 5 years ago

Enable bandit check
Omit tests from bandit check
Enable flake8
Change line length to 99 char according to Thermondo's guidelines
Enable pydocstyle
Ignore missing docstrings

codingjoe commented 5 years ago

Don't mind my commits, the changelog is in the PR comment. I did this in a browser ;)

tilboerner commented 5 years ago

@codingjoe Thanks a lot for the contribution, it's much appreciated!

@anapaulagomes:

Since this is a small project, I don't see a reason to change the limit to 100. What do you think @tilboerner? Also, we talked about adopting Black (which uses 88 as limit). We can change it afterwards.

I actually think 99 chars is a really nice limit, and would not mind adopting it. Black's 88 is a bit on the short side, I think. But it's fine to leave that for another PR; thanks for merging this one!