search

tilbud / rCMEM

GNU General Public License v3.0
2 stars 4 forks source link

Verbose option for warning about input units #32

Open HolmquistJ opened 4 years ago

HolmquistJ commented 4 years ago

Since we decided that we would not have any unit conversions in our code, right now we only work in grams for mass and centimeters for distance, area and volume. This could be an issue for users who are used to working in grams per square meter for biomass, milligrams per liter for suspended sediment concentration. Should we have a verbose option in runMemWithCohorts that detects inputs that seem like they're outside a reasonable range and prints a warning message? verbose = T could be a generic function parameter that could be set to F for experienced users who don't want to keep getting printed feedback from the function.

tilbud commented 4 years ago

I think not. But an alternative might be to provide a user activated toggle.Sent from my Verizon, Samsung Galaxy smartphone -------- Original message --------From: James Holmquist notifications@github.com Date: 2/12/20 5:05 PM (GMT-05:00) To: tilbud/rCTM rCTM@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [tilbud/rCTM] Verbose option for warning about input units (#32) Since we decided that we would not have any unit conversions in our code, right now we only work in grams for mass and centimeters for distance, area and volume. This could be an issue for users who are used to working in grams per square meter for biomass, milligrams per liter for suspended sediment concentration. Should we have a verbose option in runMemWithCohorts that detects inputs that seem like they're outside a reasonable range and prints a warning message? verbose = T could be a generic function parameter that could be set to F for experienced users who don't want to keep getting printed feedback from the function. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tilbud/rCTM/issues/32?email_source=notifications\u0026email_token=ACAWM2YXM4VLVOVW5ZQQI7TRCRW7PA5CNFSM4KUFHFS2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4INCTGHQ", "url": "https://github.com/tilbud/rCTM/issues/32?email_source=notifications\u0026email_token=ACAWM2YXM4VLVOVW5ZQQI7TRCRW7PA5CNFSM4KUFHFS2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4INCTGHQ", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

HolmquistJ commented 4 years ago

I like that. We could have biomass and ssc units be a mandatory input.