tilburgsciencehub / music-to-scrape

A fictitious music streaming service with a real website and API so you can learn how to scrape!
https://music-to-scrape.org
3 stars 6 forks source link

mobile version, search, song page #20

Closed hannesdatta closed 1 year ago

hannesdatta commented 1 year ago

I noticed that a few issues requested in #15 haven't been implemented yet.

I noticed the site fails to render well on mobile. Can you come up with a reduced-sized version of the website? Yet, rather than making this a key pillar of your development, just come up with a minimal-effort version. Drop things that don't work. Don't invest a lot into making to super super mobile friendly. The outcome should be a reduced mobile site, maybe even with less features. That would be a fantastic use case for students to decide between mobile vs. desktop versions. So: MINIMAL effort.

image

Right now, when searching for a song, you can't click on it.

image

Right now, it only says song name.

This can be as simple as saying song name, by artist x on top (analogous to what we have on the artist page)

Originally posted by @thierrylahaije in https://github.com/tilburgsciencehub/apis-to-scrape/issues/15#issuecomment-1509870742

thierrylahaije commented 1 year ago

I fixed all the issues, except pagination maximum number of pages, since I do not know what you mean exactly. All details that I have done will be posted in issue 20.

hannesdatta commented 1 year ago

I don't remember either - nevermind :).

hannesdatta commented 1 year ago

Done! Thanks so much!