Address feedback points

[hannesdatta]

Data

• [x] update readme witih instructions on how to update the data (i.e., which scripts to run)
• [x] it's also unclear how to import the CSV data to the database - did you use some code that hasn't been added anywhere?
• [x] in terms of directory structure, it's unclear to me why we have sql_app, flask_app (both are good), and then a few separate folders such as src, gen, data. Can you somehow integrate these concepts? Probably we need another main folder, called data, and everything related to the simulation etc. happens there.
• [x] It's also important to clarify why we currentely take copies of our database for flask and the api. Shouldn't this be served out of the main database?

This is important to tackle because in the future, we are going to update the simulation to gradually make the data more realistic.

Front-end

• [x] There are a few open issues that haven't been tackled (originally posted in #15), I created a new issue #20 in which I summarize the requested changes.
• [x] I noticed songs on the user page are ordered in reverse chronological order. Can you make it increasing (so, earlier songs first)?

(in this screenshot, we first should see may 20, then may 21, etc.

• [x] The colors in the menu are not aligned. The buttons have a different color than the bar (seen on firefox). Can you fix this, please?

• [x] Next week should be greyed out when there are no next weeks, right?

• [x] When interating through the page, we get a server error. Can you simply serve page 1 or page 0 if using negative numbers?

• [x] There's something wrong with the recently active users served on the landing page. When you click on them, you actually do not see that they have listened to anything in this week. Is this correct?

Feedback

• I added a bunch of files to .gitignore - it doesn't make sense versioning .DS_Store, .Rhistory files etc.
• We are still running on the small dataset, right? Let's discuss what the bottleneck is (ideally avoid committing full data to Git btw).

Next steps

• Let's get this app online together for testing and then you can tackle #19.
• I can handle #14 and #23 with another TSH RA. I can do #22.

[thierrylahaije]

Data feedback:

in terms of directory structure, it's unclear to me why we have sql_app, flask_app (both are good), and then a few separate folders such as src, gen, data. Can you somehow integrate these concepts? Probably we need another main folder, called data, and everything related to the simulation etc. happens there.

• data folder only contains a single .csv file. Do you need this file? Otherwise this folder can be removed.
• gen folder is not necessary anymore, so this folder will be removed in my next push.

• we might rename the 'src' folder to 'data'. This would simplify everything (if the data folder mentioned above can be removed of course.

  It's also important to clarify why we currently take copies of our database for flask and the api. Shouldn't this be served out of the main database?

• The database is located in 2 folders since they both have different functions (one folder is flask, one is fastapi). When deploying them, the databases must be inside the folder of the specific app (fastapi/flask). To prevent errors for users, I already placed them inside the folders, instead of specifying and outer folder.
• Furthermore, the new simulate.R file that I will push this weekend automatically creates a new database, so we do not need to make copies by hand when editing the data. We then also do not need to render the .csv files anymore, the r script will handle everything for about the data up to and including the creation of the database.

[hannesdatta]

agree with your recommendations.

data folder only contains a single .csv file. Do you need this file? Otherwise this folder can be removed.

don't need it.

gen folder is not necessary anymore, so this folder will be removed in my next push.

good

we might rename the 'src' folder to 'data'. This would simplify everything (if the data folder mentioned above can be removed of course.

agree.

---

The database is located in 2 folders since they both have different functions (one folder is flask, one is fastapi). When deploying them, the databases must be inside the folder of the specific app (fastapi/flask). To prevent errors for users, I already placed them inside the folders, instead of specifying and outer folder. Furthermore, the new simulate.R file that I will push this weekend automatically creates a new database, so we do not need to make copies by hand when editing the data. We then also do not need to render the .csv files anymore, the r script will handle everything for about the data up to and including the creation of the database.

Ok. Fine. Please update descriptions about how to update the data then and make a clear statement that we 'run' two data bases. Probably also what happens in reality...

Thanks!

[thierrylahaije]

I have done another push to address the following issues:

FastAPI:

• [x] recently_active_users: did not work correct -> changed
• [x] Featured_artists: not working - > fixed, made a change in the model. Front-end:
• [x] Featured Artists are not visible
  • [x] R studio exports true as 1 in database. Small adjustment made to make the featured artists still visible.
• [x] There's something wrong with the recently active users served on the landing page. When you click on them, you actually do not see that they have listened to anything in this week. Is this correct?
  • [x] There was an error here. Now you see the most recent track on hover, on click you got to the user page. On mobile phone, this hover is not possible.
  • [x] There also was another error, it did not get the most current artists. This is now fixed.
• [x] When interating through the page, we get a server error. Can you simply serve page 1 or page 0 if using negative numbers?
  • [x] Users now get redirected to week 0 when trying a negative number.
• [x] The user page songs were not visible.
  • [x] Problem fixed by correcting something in the .r file
• [x] The colors in the menu are not aligned. The buttons have a different color than the bar (seen on firefox). Can you fix this, please?
  • [x] Issue in style.css - fixed.
• [x] Next week should be greyed out when there are no next weeks, right?
  • [x] I removed the button now for future weeks.
  • [x] I also removed the previous button at week 0.

Issue 20:

• [x] Right now, when searching for a song, you can't click on it.
  • [x] Fixed -> Linked to Song page
• [x] Created Song Page
  • [x] Linked on places where songs are listed (homepage recently played and top 15, artist page / user page made rows clickable)
  • [x] Created Design
• [x] Styling for mobile version of the website.
  • [x] Details fixed, rest was already done. Are you checking correctly?
• [x] Search function working on every page.
  • [x] Checked, works on al pages.
• [x] Please add "artist name" to the search results for songs (song x by artist y).
  • [x] Fixed

[hannesdatta]

Thanks a bunch! I love it!