search

tilburgsciencehub / music-to-scrape

A fictitious music streaming service with a real website and API so you can learn how to scrape!
https://music-to-scrape.org
3 stars 5 forks source link

Deny action not saved? #44

Closed hannesdatta closed 1 year ago

hannesdatta commented 1 year ago

If you click on deny when being served a cookie banner and navigate to the next page, the banner reappears.

The expected behavior is that the banner will not pop up again. After all, you denied cookies. Can you fix?

Clicking on managing cookies, and then saving them does save your choice. But it needs to still minimize the banner when it is still open. Can you also fix this?

Please also investigate whether this is an issue at Tilburg Science Hub.

thierrylahaije commented 1 year ago

@hannesdatta first issue is probably an easy fix, minor mistake. I do not really understand your second point about "minimize the banner when it is still open", could you clarify?

These issues are not related to TSH. I made this cookie banner + script myself. The other one was provided by Hugo itself, which I only needed to implement and adjust.

thierrylahaije commented 1 year ago

Nevermind, I understood what you meant. I made the necessary changes for both issues. I will push this in 5 minutes.