search

tilburgsciencehub / website-flask

0 stars 2 forks source link

menu empty #45

Closed hannesdatta closed 2 months ago

hannesdatta commented 2 months ago

The menu is empty when running the site in Docker using docker compose build & docker compose up -d.

image

I think this may have to do with the fact that the :5000 port was hardcoded in the code, e.g. https://github.com/tilburgsciencehub/website-flask/blob/db3839dc159e0f47fa2a75c30a65568b51a179b1/functions.py#L131 and https://github.com/tilburgsciencehub/website-flask/blob/db3839dc159e0f47fa2a75c30a65568b51a179b1/html_parser.py#L359.

Docker runs this site via gunicorn on 8000 (wouldn't hard code 8000 either - should be something that dynamically adapts...).

thierrylahaije commented 2 months ago

Issue has been fixed, root and base url are now dynamic.

hannesdatta commented 2 months ago

Hi @thierrylahaije, this did not solve my initial issue: the menu is still empty.

image image

Please fix.

How to reproduce docker compose build docker compose up -d

thierrylahaije commented 2 months ago

Hi @hannesdatta,

Sorry, I thought the issue had to do with the URL. I checked what is going wrong, and it seems that since the docker-compose.yml has been added, something is going wrong with the defaultdict part of the collections library. Normally, this should be a basic function from the python base, but for some reason, something is going wrong and I have not been able to find out yet why this is happening. I need to further investigate this.

thierrylahaije commented 2 months ago

Fix in PR #49