Open VirginiaMirabile opened 3 months ago
Hi @VirginiaMirabile,
I had a look over it. It reads super clear! I made a few comments that might be useful! And also something general I noticed:
Since the causal inference content is rearranged, there is a new section for Synthetic control, I would include it in there instead of the Introduction section!
Also, the topic that now exists already (https://tilburgsciencehub.com/topics/analyze/causal-inference/synthetic-control/synth-control/) might be overlapping in some ways. We can maybe adjust this content so it's complementary (it's still useful as it contains Stata code as well), but adjust it as a follow-up on your article such that the content is not overlapping?
Let me know if something is unclear!
@VirginiaMirabile did you include the feedback? Can I merge ? :)
@alexandervossen I need to review this PR too. Will do so by end of this week (caught up with bunch of grading deadlines)..
@VirginiaMirabile Added my comments :) As discussed feel free to pick new stuff from the older BB on SCM (e.g. STATA codes) and other impo points: https://tilburgsciencehub.com/topics/analyze/causal-inference/synthetic-control/synth-control/
I believe Gaston had written the older one.. in case you borrow stuff from there would be good to add him as co-author in the new version :) @lachlandeer @alexandervossen we might have to remove the older version as this is more complete.
Hi @srosh2000 @valerievossen, I have uploaded the revised building block version implementing your feedback. The main changes include:
Let me know if any further work is needed!
@VirginiaMirabile Looks good!
Can you still move the topic to the synthetic control section of causal inference, (it is now in the introduction section). Maybe you need to merge the master into this branch first to see the synthetic control section locally?
And some small comments to make the text easier to read:
smoking
dataset, the tidysynth
package, the time index (year
), or plot_differences()
Hi @VirginiaMirabile , let us know when you are ready with these changes!
Hi all, I have addressed all the latest feedback. For some reason, the folder of causal inference doesn't show up for me so I can't move it just yet. I will try to figure it out, but if you know why that might be let me know!
✅ Deploy Preview for unique-scone-f4eb67 ready!
Toggle QR Code...
Use your smartphone camera to open QR code link.
To edit notification comments on pull requests, go to your Netlify site configuration.