tilburgsciencehub / website

Learn to work more efficiently on empirical research projects.
https://tilburgsciencehub.com
38 stars 48 forks source link

uploading bb synthetic control methods and associated images #1208

Open VirginiaMirabile opened 3 months ago

netlify[bot] commented 3 months ago

Deploy Preview for unique-scone-f4eb67 ready!

Name Link
Latest commit 185d59292f0bbee2078937773a262dbf0927d43d
Latest deploy log https://app.netlify.com/sites/unique-scone-f4eb67/deploys/66b8cbb82e1e1b0008a05c27
Deploy Preview https://deploy-preview-1208--unique-scone-f4eb67.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

valerievossen commented 3 months ago

Hi @VirginiaMirabile,

I had a look over it. It reads super clear! I made a few comments that might be useful! And also something general I noticed:

Let me know if something is unclear!

alexandervossen commented 3 months ago

@VirginiaMirabile did you include the feedback? Can I merge ? :)

srosh2000 commented 3 months ago

@alexandervossen I need to review this PR too. Will do so by end of this week (caught up with bunch of grading deadlines)..

srosh2000 commented 3 months ago

@VirginiaMirabile Added my comments :) As discussed feel free to pick new stuff from the older BB on SCM (e.g. STATA codes) and other impo points: https://tilburgsciencehub.com/topics/analyze/causal-inference/synthetic-control/synth-control/

I believe Gaston had written the older one.. in case you borrow stuff from there would be good to add him as co-author in the new version :) @lachlandeer @alexandervossen we might have to remove the older version as this is more complete.

VirginiaMirabile commented 2 months ago

Hi @srosh2000 @valerievossen, I have uploaded the revised building block version implementing your feedback. The main changes include:

Let me know if any further work is needed!

valerievossen commented 2 months ago

@VirginiaMirabile Looks good!

Can you still move the topic to the synthetic control section of causal inference, (it is now in the introduction section). Maybe you need to merge the master into this branch first to see the synthetic control section locally?

And some small comments to make the text easier to read:

shrabasteebanerjee commented 2 months ago

Hi @VirginiaMirabile , let us know when you are ready with these changes!

VirginiaMirabile commented 1 month ago

Hi all, I have addressed all the latest feedback. For some reason, the folder of causal inference doesn't show up for me so I can't move it just yet. I will try to figure it out, but if you know why that might be let me know!