tildaslash / RatticWeb

Password Management for Humans
http://rattic.org/
GNU General Public License v2.0
474 stars 149 forks source link

Password Generator Length Issue #424

Open aaronrobertson opened 8 years ago

aaronrobertson commented 8 years ago

When no 'Can Have' options are checked in the password generator page, the generated password does not meet the Password Length setting.

Recommend changing line in /static/rattic/js/newcore.js from

if ($('#chk_can_' + key).is(":checked")) canset.push(key);

to

if ($('#chk_can_' + key).is(":checked") || $('#chk_must_' + key).is(":checked")) canset.push(key);

This would logically imply that any option clicked as a 'Must Have' qualifies as a 'Can Have'.