tildaslash / RatticWeb

Password Management for Humans
http://rattic.org/
GNU General Public License v2.0
475 stars 149 forks source link

Fix requirement versions #444

Open jwmarshall opened 8 years ago

jwmarshall commented 8 years ago

This PR will fix various pip module versions in the requirements. I've verified the build via Travis using the tests already in this repo.

https://travis-ci.org/jwmarshall/RatticWeb/builds/130076774

jwmarshall commented 8 years ago

This resolves issue https://github.com/tildaslash/RatticWeb/issues/405

jwmarshall commented 8 years ago

@Zemmiph0bia @smarthall I know you guys are really busy but can we at least get this merged so that the current version builds correctly? Thank you.

angystardust commented 8 years ago

Maybe it's time to fork... https://github.com/danislav/RatticWeb

jwmarshall commented 8 years ago

@angystardust the problem with another fork is simply knowing wether or not the person(s) plan to keep supporting it or if they've only forked it to only fix one issue.

@Zemmiph0bia @smarthall perhaps we could add some additional contributors to this project to help manage incoming pull requests?

All things considered I've tested my PR several times, and have since deployed my fork to production with zero issues, not to mention it passes in TravisCI which your current master branch does not. Would love to see this merged soon. You mentioned on twitter late last year that this was not a dead project, please merge this PR so it can also be a working project.

jwmarshall commented 8 years ago

Considering this is still open and nobody with access to the repo has even commented this project is pretty much dead in all the ways that matter.

jwmarshall commented 7 years ago

Three months now with no answers 👎

orsenthil commented 7 years ago

@jwmarshall - is your fork building or running tests successful? Anyone who is going to try is going to hit with the build problem and possibly going to stumble upon this discussion.

orsenthil commented 7 years ago

Actually, if you rebase and push it, you can encounter failures.

On local setup, I hit this problem.

$ ./runtests.sh
Running PEP8 (pep8 --exclude=migrations,lib,static,.ropeproject --ignore=E501,E225,E128,E124 .)...  [30486 refs]
Success
Running pyflakes (./pyflakes.sh)...  [77070 refs]
Success
Running Unit Tests (./manage.py test )...  Traceback (most recent call last):
  File "./manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/Users/senthil/python2.7/ratticweb/lib/python2.7/site-packages/django/core/management/__init__.py", line 399, in execute_from_command_line
    utility.execute()
  File "/Users/senthil/python2.7/ratticweb/lib/python2.7/site-packages/django/core/management/__init__.py", line 392, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/Users/senthil/python2.7/ratticweb/lib/python2.7/site-packages/django/core/management/__init__.py", line 272, in fetch_command
    klass = load_command_class(app_name, subcommand)
  File "/Users/senthil/python2.7/ratticweb/lib/python2.7/site-packages/django/core/management/__init__.py", line 75, in load_command_class
    module = import_module('%s.management.commands.%s' % (app_name, name))
  File "/Users/senthil/python2.7/ratticweb/lib/python2.7/site-packages/django/utils/importlib.py", line 40, in import_module
    __import__(name)
  File "/Users/senthil/python2.7/ratticweb/lib/python2.7/site-packages/django_nose/__init__.py", line 5, in <module>
    from django_nose.runner import BasicNoseRunner, NoseTestSuiteRunner
  File "/Users/senthil/python2.7/ratticweb/lib/python2.7/site-packages/django_nose/runner.py", line 19, in <module>
    from django import setup
ImportError: cannot import name setup
[113203 refs]
Failure
jwmarshall commented 7 years ago

I simply ran the tests as they existed in the repository. Did you make sure to install the various requirements?

Have a look at the .travis.yml to see the exact commands and steps used for testing.

https://github.com/tildaslash/RatticWeb/blob/master/.travis.yml

orsenthil commented 7 years ago

Actually, lots has changed that those .trave.yml is no longer valid. ( For e.g: https://github.com/tildaslash/RatticWeb/pull/454 )

or you can try it by pushing an empty commit to this same PR and trying to build again.

jwmarshall commented 7 years ago

Closed and reopened to test. Indeed the checks have failed. I will have to review what changes were made since this PR was opened. I'm honestly surprised that any were made without anyone even looking at this PR for months.