search

tilde-lab / metis-client

Metis infrastructure API client in Python
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

sock_connect vs. timeout? #42

Open blokhin opened 11 months ago

blokhin commented 11 months ago

Documented in https://docs.aiohttp.org/en/stable/client_reference.html, sock_connect is set to 10 minutes, which might be too much:

https://github.com/tilde-lab/metis-client/blob/00639fa2c09031c9ff5e787b2b49441dcd3b45bd/metis_client/client.py#L238

How is it related to a general client timeout?

knopki commented 11 months ago

Related issues: https://github.com/rtfol/aiohttp-sse-client/issues/2 and https://github.com/rtfol/aiohttp-sse-client/issues/161

These are timeouts for SSE stream, and general client's timeout is not applied here. timeout and sock_read should be None's or stream will be terminated. Not sure about sock_connect... maybe None is fine too.