tildearrow / furnace

a multi-system chiptune tracker compatible with DefleMask modules
GNU General Public License v2.0
2.25k stars 200 forks source link

"Set volume: 72 (48, 56%)", The "56%" should be 18.75%. #1828

Closed gtr3qq closed 5 months ago

gtr3qq commented 5 months ago

Discussed in https://github.com/tildearrow/furnace/discussions/1822

Originally posted by **gtr3qq** March 25, 2024 ![Screenshot 2024-03-25 025357](https://github.com/tildearrow/furnace/assets/76813695/7ee68c3c-562a-477f-a473-e62bd0b4df2a) _Spotted this while doing a tune with OPM. Can hardly contain myself from giggles. 😂 Less kinder ones might moan after all that branding of Exp.Volume.... But I'm not one of those. If my maths didn't all returns to my teacher, this value should be a volume about 18.75%. Please remove/patch this. 🤣 Thank you for your amazing tracker!_

Above are the discussion, I'm not really sure if this is worked as intention. The linear percentages feels like the intent was to mark the volume as percent. But in doing so, forget about exp. scale used for Furnace, i.e. a bug. Else I don't really see what's the point of having this percentage of the value. FurnaceLogVtopercent This is a function I cobbled to covert the exp. value to liner....? Uni was a long time ago.😂 e.g. if input a X value of 24, 24/64 of the volume used in OpenMPT and others, the Y is the expected value to put in the furnace tracker 48. It might be more elegant to use logarithmic function since the X and Y are swapped, and I'm not quite sure if the base should be 2. 🤣 Maths! Brain! Good!

If this is not a bug, I'll close this as fast as possible.

Thanks.

tildearrow commented 5 months ago

Fixed!