tildearrow / furnace

a multi-system chiptune tracker compatible with DefleMask modules
GNU General Public License v2.0
2.08k stars 188 forks source link

Certain S3M songs will make furnace crash when imported. #1965

Closed pcbcat closed 1 week ago

pcbcat commented 1 week ago

When I tried to play a song to test out the S3M support, furnace crashed.

The log had the following text:

Stack trace (most recent call last): 14 Object "", at 0x7ffd45b4257d, in BaseThreadInitThunk 13 Object "", at 0x7ff62d8b13e6, in ?? 12 Object "", at 0x7ff62d8b12ee, in ?? 11 Object "", at 0x7ff62e1c6c26, in ZN9RtMidiOutC1EN6RtMidi3ApiERKNSt7cxx1112basic_stringIcSt11char_traitsIcESaIcEEE 10 Object "", at 0x7ff62dbbdcc3, in ?? 9 Object "", at 0x7ff62de680cb, in IGFD_DisplayDialog 8 Object "", at 0x7ff62de5ac13, in IGFD_DisplayDialog 7 Object "", at 0x7ff62d943860, in ?? 6 Object "", at 0x7ff62d99de6b, in ?? 5 Object "", at 0x7ff62d8b700c, in ?? 4 Object "", at 0x7ff62e213a33, in ZN9RtMidiOutC1EN6RtMidi3ApiERKNSt7cxx1112basic_stringIcSt11char_traitsIcESaIcEEE 3 Object "", at 0x7ff62e211073, in ZN9RtMidiOutC1EN6RtMidi3ApiERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE 2 Object "", at 0x7ff62e321b21, in ZNK9RtMidiOut10isPortOpenEv 1 Object "", at 0x7ff62e2f2fa6, in ZNK9RtMidiOut10isPortOpenEv 0 Object "", at 0x7ff62e2ec223, in ZNK9RtMidiOut10isPortOpenEv

I also grabbed some other songs from The Mod Archive and some from a Zone 66 S3M music rip I had, the result was the same for each song.

Below I have attached a .zip that has the songs I played as well as the log.

s3mcrash.zip

tildearrow commented 1 week ago

Please test with Git master. Crash no longer occurs with any of the modules in the set you've submitted.

a_dream_comes takes a while to load but this will be diagnosed later.

pcbcat commented 1 week ago

Tested, no longer crashes when importing the songs.

Used this version