tildearrow / furnace

a multi-system chiptune tracker compatible with DefleMask modules
GNU General Public License v2.0
2.08k stars 188 forks source link

ADSR problem on some chips #1973

Closed agajgjsa592586 closed 1 day ago

agajgjsa592586 commented 1 week ago

https://github.com/tildearrow/furnace/assets/170561830/43a24e54-c463-4814-a522-f72d852db101

Here is the clip up there. I was having a problem making this instrument. plus it goes up back to the max wavetable volume too.

agajgjsa592586 commented 1 week ago

The bug is also confirmed when new releases from Furnace. as a case. it should be fixed for example. Alice in Wonderland remixed from Namco C30.

https://github.com/tildearrow/furnace/assets/170561830/97844b0d-16de-4756-9aa3-5773276126c1

agajgjsa592586 commented 1 week ago

This is confirmed from Wavetables and the others: X1-010, WonderSwam, Virtual Boy, KBSWSG, SCC, Namco WSG, C15, C30, POKEY, Atari Lynx, CPET, SM8521, and Nintendo DS. but all Sound chips are not confirmed this yet.

agajgjsa592586 commented 1 week ago

Here are more clips from these sound chips from this problem, since I changed the title to ADSR problem on some chips

https://github.com/tildearrow/furnace/assets/170561830/65c9092a-4939-4a4a-b27a-f15b53a7ef38

tildearrow commented 1 week ago

Version of Furnace?

(what happened to my comment? I thought I posted it!)

agajgjsa592586 commented 6 days ago

I used the version for 0.6.4 and 0.6.5. which makes it messed up. When using ADSR on some chips. The max volume for the bottom and 0 for the top to prove it. And change anything for the attack you want. For 1-255. but if you know that you post the comment. You realize that you didn't save it or submit it probably.

Flipleerr commented 5 days ago

able to reproduce the bug, used a build i compiled myself from the latest commit i think. used Namco WSG for the example below.

https://github.com/tildearrow/furnace/assets/102913083/30fb3148-6b9b-434f-95c5-656fd6293cba

(ignore the funny audio, the wavetable's a clean sawtooth)

seems to be intended behavior though, when increasing the top value the ADSR envelope gets applied (i think top and bottom just act as volume layers) this is just inverse from the default, and the envelope gets applied in reverse

tildearrow commented 1 day ago

Fixed!