Various OPLL problems and corruptions

[freq-mod]

• [x] 02xx portamento down (and most likely 01xx up) doesn't work right on drums. On Snare, it also activates the hihat, even if nothing is in hi-hat's track. Happen with tom and cymbal too.
• [x] E1xx and E2xx should not stop when Key OFF comes in (?)
• [x] #749
• [x] KSL for carrier and mod are swapped, op1 affects op2's and vice versa
• [x] AR is 4-bit like the rest of ADSR envelope, not 5-bit
• [x] What is "Duty/Noise" and "waveform" macros for?
• [x] Drum mode in general needs a quite of a revamp: https://discord.com/channels/936515318220722197/948564499965816852 (hope teh link werks)
• [x] OPLLTest(1).zip this module demonstrates the serious bug: on channel 1, pattern 1 onward, the oboe instrument gets corrupted really badly, with it's volume fluctuating in a chaotic way and and entire timbre goes off
• [x] SUS doesn't work
• [x] make HH and T-CY not write into freq register. The reason for that is when snare and hi hat are in the same row snare's frequency register update will be overshadowed by hi hat's. Same goes for tom and cymbal where cymbal overshadows tom Suggestion after fix: when song plays if no note is present in snare or tom (or there is key OFF and REL) set the yamaha's default frequency registers for it
• [ ] And an option to choose between different (adlib, Yamaha, SMPS, MGSDRV) freq settings for drum mode (see: 7)
• [x] nvmind, drums instrument preset must be used on drums
• [x] #261
• [x] Ability to see built-in instrument parameters grayed out, like DM and DC checkboxes
• [x] Ability to use different variants' FM instrument voice banks. Nuked OPLL allows it
• [x] OPLL built-in patch preview is broken for VRC7 and other non-2413 banks, it will display 2413 FM params, which is plainly incorrect

[tildearrow]

I have turned your issue into a list to make it easier for me to track.

[tildearrow]

AR is 4-bit in OPL/OPLL. Not a bug.

[tildearrow]

What is "Duty/Noise" and "waveform" macros for?

Unused. I am hiding these now.

[tildearrow]

make HH and T-CY not write into freq register. The reason for that is when snare and hi hat are in the same row snare's frequency register update will be overshadowed by hi hat's. Same goes for tom and cymbal where cymbal overshadows tom Suggestion after fix: when song plays if no note is present in snare or tom (or there is key OFF and REL) set the yamaha's default frequency registers for it

Added an option for this.

[tildearrow]

And an option to choose between different (adlib, Yamaha, SMPS, MGSDRV) freq settings for drum mode (see: 7)

Do you have a list? (besides Yamaha)

[freq-mod]

I will try to find one tomorrow

[freq-mod]

@tildearrow it might be very wrong, but: Adlib Visual Composer: BD - variable (2B2 for BD); SD and HH - 205; TOM and CYM - 2B2. MDPlayer also specified some BL values, no idea what are they- 5 for BD, 2 for SD, 1 for cym. Will test it. EDIT: tested, wrong lol

SMPS (real) CH7: block = 2, f-num = 288 CH8: block = 0, f-num = 432 CH9: block = 0, f-num = 257

[freq-mod]

OPLL built-in instr parameters wiev is incorrect - OP1 and OP2 Sine checkboxes are ignored, making one think all sounds use sine, which is not the case.

[freq-mod]

Remaining issues tracked in separate tickets

[tildearrow]

Created new label for this specific situation.