tildearrow / furnace

a multi-system chiptune tracker compatible with DefleMask modules
GNU General Public License v2.0
2.63k stars 207 forks source link

Implement Auto Envelope (SSG/AY) (Suggestion) #32

Closed TheDuccinator closed 2 years ago

TheDuccinator commented 2 years ago

Similar to FamiTracker with the Sunsoft 5B. Users can set envelope shape, pitch of the envelope, and tie it to the note placed down on the pattern.

TheDuccinator commented 2 years ago

https://user-images.githubusercontent.com/66538032/150213940-1663588f-6656-4522-af1f-79d494cc1c5a.mp4

freq-mod commented 2 years ago

mentioned it already, but good to have a separate issue for that. Auto envelope is crazy useful, allowing square/envelope masking and even ultrasonic EG (especially useful for AY8930)

TheDuccinator commented 2 years ago

Yeah, I agree. Setting the envelope pitch manually is painfully hard. Also, I did not know it was already mentioned.

tildearrow commented 2 years ago

Implemented for 0.4.6.

freq-mod commented 2 years ago

It doesn't work. On Famitracker, C-4 note with H9C (autoenvelope with shift of (9-8) and shape C (sth like sawtooth) produces a sound. Here, only a click can be hard with 29xy with same params. Envelope mode was set both in instrument settings and via 20xx effect. Freshly built from source

tildearrow commented 2 years ago

Effect 20xx does not set the envelope shape. Effect 22xy does.

freq-mod commented 2 years ago

it still does not produce sound, with or without these effects.

tildearrow commented 2 years ago

Try 2281 and 2911 at the same time. Auto-envelope is implemented like this for greater flexibility:

freq-mod commented 2 years ago

ah ok, it works. I have been confused by numerator/denominator terminilogy